Skip to content

Conversation

woile
Copy link
Member

@woile woile commented May 29, 2020

Closes #192

Types of changes

Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Empty lines at the beginning of the changelog

Checklist:

  • Add test cases to all the changes you introduce
  • Run ./script/lint and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
    Update the documentation for the changes

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Create a commit
  2. Run cz changelog --incremental
  3. Create a commit
  4. Run cz changelog --incremental
  5. Create a commit
  6. Run cz changelog --incremental

Expected behavior

No new extra lines are added

Related Issue

#192

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #193 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          35       35           
  Lines         967      968    +1     
=======================================
+ Hits          891      892    +1     
  Misses         76       76           
Flag Coverage Δ
#unittests 92.14% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/changelog.py 91.89% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601bd29...11b177f. Read the comment docs.

@woile woile requested a review from Lee-W May 29, 2020 08:22
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Lee-W Lee-W merged commit 36de56d into master May 29, 2020
@Lee-W Lee-W deleted the 192-empty-lines branch June 5, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] cz bump --changelog adds empty lines to the beginning of the CHANGELOG.md
2 participants