Skip to content

Conversation

bjoluc
Copy link
Contributor

@bjoluc bjoluc commented Jun 1, 2020

Types of changes

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Remove the typing dependency. The typing module is included in stdlib since Python 3.5.

Checklist:

  • Add test cases to all the changes you introduce
  • Run ./script/lint and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

The typing module is included in stdlib since Python 3.5.
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          35       35           
  Lines         968      968           
=======================================
  Hits          892      892           
  Misses         76       76           
Flag Coverage Δ
#unittests 92.14% <100.00%> (ø)
Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbcc922...119d729. Read the comment docs.

@woile woile merged commit f616e6e into commitizen-tools:master Jun 1, 2020
@bjoluc bjoluc deleted the remove-typing branch June 1, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants