Update customization.md #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2020 12:48
blaggacao
commented
Jun 9, 2020
| | `name` | `str` | `None` | The key for the value answered by user. It's used in `message_template` | | ||
| | `message` | `str` | `None` | Detail description for the question. | | ||
| | `choices` | `list` | `None` | (OPTIONAL) The choices when `type = choice`. It should be list of dictionaries with `name` and `value`. (e.g., `[{value = "feature", name = "feature: A new feature."}, {value = "bug fix", name = "bug fix: A bug fix."}]`) | | ||
| | `choices` | `list` | `None` | (OPTIONAL) The choices when `type = list`. Either use a list of values or a list of dicitionaries with `name` and `value` keys. See examples above. | |
There was a problem hiding this comment.
Maybe define the proper type set supported by upstream library in this way.
|
Please squash-merge with proper commit message I just did a quick one-shot modification over github ui to fix what caused confusion. See: https://gist.github.com/piscisaureus/3342247 to attend such contributions more easily. |
|
Thanks for updating! I just squahed and merged it. |
|
Super cool, I hope it's clearer now for future readers. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #202 - also fixes other inconsistencies which contributed to my initial confusion.