feat(cz_check): cz check can read from a string input #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 96.58% 96.61% +0.02%
==========================================
Files 33 33
Lines 908 915 +7
==========================================
+ Hits 877 884 +7
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Lee-W
requested changes
Aug 31, 2020
tests/commands/test_check_command.py
Outdated
| assert all([msg in str(excinfo.value) for msg in ill_formated_commits_msgs]) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("args", [{"message": "fix(scope): some commit message"}]) |
There was a problem hiding this comment.
We don't need parametrize here unless we add more test input.
tests/commands/test_check_command.py
Outdated
| success_mock.assert_called_once() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("args", [{"message": "bad commit"}]) |
jordanSu
force-pushed
the
cz-check-message
branch
from
6e6e66c to
65ae829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #200 , this PR make
cz checkcan read a string input as an argument with "--message"Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
With "-m" or "--message",
cz checkchecks string input as commit message.Steps to Test This Pull Request
cz check -m COMMIT_MESSAGEcz check --message COMMIT_MESSAGEAdditional context
Refer to issue #200