Skip to content

Conversation

alecgerona
Copy link
Contributor

@alecgerona alecgerona commented Sep 2, 2020

Closes #258

Description

Rewrite cli instructions to be more succinct about what they require.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

1.Run cz c and view messages.

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          33       33           
  Lines         915      915           
=======================================
  Hits          884      884           
  Misses         31       31           
Flag Coverage Δ
#unittests 96.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...en/cz/conventional_commits/conventional_commits.py 98.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efb23f...45ca91e. Read the comment docs.

@alecgerona alecgerona requested a review from woile September 2, 2020 16:00
@woile woile requested a review from Lee-W September 3, 2020 07:25
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Lee-W Lee-W merged commit 683317b into commitizen-tools:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Be more verbose about which input is required or optional
3 participants