fix(commands/commit): create tmp file divided by user info #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multi user siuation, it may get fail `Permission denied: '/tmp/cz.commit/backup` due to another user create a temp file. So if one user create temp_file should attatch with USER info to resolve permission issue
|
Nice, thanks! You'll have to run |
woile
reviewed
Dec 16, 2020
| self.temp_file: str = os.path.join(tempfile.gettempdir(), "cz.commit.backup") | ||
| name = "cz.commit.backup" | ||
| if "USER" in os.environ: | ||
| name = name + "." + os.environ['USER'] |
There was a problem hiding this comment.
I'd prefer something like this:
user = os.environ.get('USER', "")
name = f"cz.commit{user}.backup
There was a problem hiding this comment.
Thank you for the apply. we have 100+ users project using this package which have this issue, but I am new commiter for this python package. I will rebuild this issue only after work.
| name = name + "." + os.environ['USER'] | ||
| self.temp_file: str = os.path.join(tempfile.gettempdir(), name) | ||
|
|
||
| def read_backup_message(self) -> str: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multi user siuation, it may get fail
The reason is another user has already created a temp file with the same name.
So if one user create temp_file should attatch with
$USERinfo to resolve permission issueDescription
attach user info to temp-file name when $USER is possible
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
create
/tmp/cz.commit.backup.tomSteps to Test This Pull Request
Additional context