Skip to content

Conversation

vinayvennela
Copy link
Contributor

Fix issue number #336.

Fix deprecated warning of loading yaml config file.

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

Fix issue number commitizen-tools#336.

Fix deprecated warning of loading yaml config file.
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #337 (0a601f8) into master (1a33099) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          35       35           
  Lines        1000     1000           
=======================================
  Hits          972      972           
  Misses         28       28           
Flag Coverage Δ
unittests 97.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 97.50% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 94.44% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)
commitizen/git.py 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9ba6f...0a601f8. Read the comment docs.

@woile
Copy link
Member

woile commented Feb 1, 2021

Thanks! Please rename the commit message to match conventional commits. E.g: fix: remove yaml warnings when using `.cz.yaml`

I can do it as well, let me know if you want me to do it

@vinayvennela
Copy link
Contributor Author

@woile Oops! got a couple of dummy commit messages added. Should I create a new PR?

@Lee-W
Copy link
Member

Lee-W commented Feb 2, 2021

@vinayvennelaI think rebasing it might be an easier solution. Try git rebase -i 🙂

@vinayvennela vinayvennela deleted the fix/update-yaml-loader branch February 2, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants