Skip to content

Conversation

woile
Copy link
Member

@woile woile commented Feb 2, 2021

Reading the docs from the action it says that it may have issues if running on ubuntu.
I thought it would be nice to run on macos and see if it works

https://github.com/dawidd6/action-homebrew-bump-formula

@woile woile requested a review from Lee-W February 2, 2021 09:35
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #339 (0de30b9) into master (1a33099) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          35       35           
  Lines        1000     1000           
=======================================
  Hits          972      972           
  Misses         28       28           
Flag Coverage Δ
unittests 97.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 97.50% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 94.44% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)
commitizen/git.py 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaba2b6...0de30b9. Read the comment docs.

@woile
Copy link
Member Author

woile commented Feb 2, 2021

mental note: if this doesn't work I'll ask to the developer of the action to help us out

@Lee-W Lee-W merged commit 3ef5257 into master Feb 2, 2021
@Lee-W Lee-W deleted the fix/ci-homebrew branch February 2, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants