Skip to content

Conversation

loonghao
Copy link

Description

This MR is fix #349

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #350 (ca99fbd) into master (1605d69) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          35       35           
  Lines         999      999           
=======================================
  Hits          972      972           
  Misses         27       27           
Flag Coverage Δ
unittests 97.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/config/__init__.py 100.00% <100.00%> (ø)
commitizen/config/base_config.py 100.00% <100.00%> (ø)
commitizen/config/json_config.py 100.00% <100.00%> (ø)
commitizen/config/toml_config.py 100.00% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2387ea7...ca99fbd. Read the comment docs.

@woile
Copy link
Member

woile commented Feb 21, 2021

This is great, thanks! I'd like to ask you to squash the commits and leave just one.
Something like:

fix(config): change read mode from `r` to `rb`

@loonghao loonghao closed this Feb 21, 2021
@loonghao
Copy link
Author

@woile Sorry for that, I can't fix squash the commits. so I create a new MR to quick fix this.

@loonghao loonghao reopened this Feb 21, 2021
@loonghao loonghao closed this Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to read configuration containing Chinese words
2 participants