Skip to content

Conversation

TheNomet
Copy link

@TheNomet TheNomet commented Oct 6, 2021

Description

Removing the venv folder from the scope of pydocstyle.
When having the venv set up in the project forlder, pydocstyle fails because of some libraries not being complainant.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

When running ./scripts/test with venv folder in the project folder, the script should not fail.

Steps to Test This Pull Request

  1. set up venv in project folder
  2. run ./scripts/test

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #443 (54a438f) into master (ca0e4bc) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   97.90%   97.36%   -0.54%     
==========================================
  Files          39       39              
  Lines        1384     1406      +22     
==========================================
+ Hits         1355     1369      +14     
- Misses         29       37       +8     
Flag Coverage Δ
unittests 97.36% <100.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 95.45% <ø> (-2.17%) ⬇️
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/version.py 100.00% <100.00%> (ø)
commitizen/config/base_config.py 90.47% <0.00%> (-9.53%) ⬇️
commitizen/cz/base.py 97.22% <0.00%> (-2.78%) ⬇️
commitizen/git.py 97.95% <0.00%> (-2.05%) ⬇️
commitizen/__main__.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976d5d2...54a438f. Read the comment docs.

@Lee-W
Copy link
Member

Lee-W commented Oct 6, 2021

As we manage our env through poetry, I'm wondering why do you need venv in this directory?

@TheNomet
Copy link
Author

That is a good point, it was my mistake to create a venv before setting up poetry. Feel free to disregard this PR.

@TheNomet TheNomet closed this Oct 11, 2021
@TheNomet TheNomet deleted the fix/exclude_venv_folder branch October 11, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants