Skip to content

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Dec 14, 2021

Description

add typing_extension to prod dep as it's required in commitizen/defaults.py

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

error should no longer happen

Steps to Test This Pull Request

  1. poetry install
  2. poetry run python commitizen/defaults.py

Additional context

#458

@Lee-W Lee-W requested a review from woile December 14, 2021 02:36
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #459 (48f9b7e) into master (65645e0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   97.92%   97.96%   +0.04%     
==========================================
  Files          39       39              
  Lines        1395     1424      +29     
==========================================
+ Hits         1366     1395      +29     
  Misses         29       29              
Flag Coverage Δ
unittests 97.96% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/changelog.py 95.77% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/bump.py 100.00% <100.00%> (ø)
commitizen/commands/init.py 91.66% <100.00%> (ø)
commitizen/config/base_config.py 100.00% <100.00%> (ø)
commitizen/config/json_config.py 100.00% <100.00%> (ø)
commitizen/config/toml_config.py 100.00% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)
commitizen/cz/base.py 100.00% <100.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7e866...48f9b7e. Read the comment docs.

@woile woile merged commit a3ef114 into master Dec 14, 2021
@woile woile deleted the add-missing-deps branch December 14, 2021 06:59
@woile
Copy link
Member

woile commented Dec 14, 2021

I will manually bump 😅 as the previous version doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants