Skip to content

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Sep 23, 2023

Description

Drops support for Python 3.7 and updates the necessary dependencies.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Sep 23, 2023

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 23, 2023 02:16
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As 3.7 has reached end-of-life, I think it makes sense to remove it. @woile I'm going to merge it these days. Let me know if you have any thought

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Sep 23, 2023
@Lee-W Lee-W merged commit 7afe877 into commitizen-tools:master Sep 25, 2023
@edgarrmondragon edgarrmondragon deleted the feat/drop-py37 branch September 25, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7
3 participants