Skip to content

Conversation

vantaboard
Copy link
Contributor

Description

Fixes a typo.

image

Checklist

  • Update the documentation for the changes

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (120d514) 97.33% compared to head (0ce193c) 97.43%.
Report is 150 commits behind head on master.

Files Patch % Lines
commitizen/cli.py 82.14% 5 Missing ⚠️
commitizen/providers/scm_provider.py 91.17% 3 Missing ⚠️
commitizen/git.py 80.00% 2 Missing ⚠️
commitizen/changelog_formats/__init__.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   97.33%   97.43%   +0.09%     
==========================================
  Files          42       55      +13     
  Lines        2104     2341     +237     
==========================================
+ Hits         2048     2281     +233     
- Misses         56       60       +4     
Flag Coverage Δ
unittests 97.43% <97.93%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-modification and removed pr-status: wait-for-review labels Jan 13, 2024
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vantaboard , thanks for opening this PR. Could you please reword the commit to docs(version_scheme): fixed typo sever -> semver so that this PR won't trigger a version bump? You can do so by

git commit --amend
git push origin --force

@vantaboard vantaboard force-pushed the fix/typo-version_scheme branch from 460bc04 to 0ce193c Compare January 13, 2024 01:49
@vantaboard
Copy link
Contributor Author

Hi @vantaboard , thanks for opening this PR. Could you please reword the commit to docs(version_scheme): fixed typo sever -> semver so that this PR won't trigger a version bump? You can do so by

git commit --amend
git push origin --force

Done!

@Lee-W Lee-W merged commit a10ba84 into commitizen-tools:master Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-modification pr-status: wait-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants