Skip to content

Conversation

sno2
Copy link
Contributor

@sno2 sno2 commented Jun 1, 2021

Rather have tests than no tests.

Copy link
Member

@AndersDJohnson AndersDJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sno2 Thanks for the contribution! I agree, tests are better than no tests, so this is good! 🚀

Just to be sure it's asserting correctly, I pulled the changes locally, made an invalid change to the JSON, and confirmed the test fails with exit code 1 as expected. 👍

Screen Shot 2021-06-04 at 7 54 19 PM

@AndersDJohnson AndersDJohnson changed the title feat: add json specification test: add json specification Jun 5, 2021
@AndersDJohnson AndersDJohnson merged commit c3a9be4 into commitizen:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants