Throw an error if there are no staged files

[kentcdodds]

There's no reason to fill out the prompts if there are no staged files. You can determine this with:

git diff --cached

:-)

[jimthedev]

Great idea. Seems like a no brainier.

[kentcdodds]

What needs to happen for this to be implemented? This catches me up pretty much every single time and I also have githooks that take my commits about 15 seconds to go through so I don't realize my mistake until after that's done :-( This would be really helpful.

[jimthedev]

Up until now, I've created any of the features I needed in gulp-git. It is a project that is built for gulp, but we use it specifically for the library modules. I'd love to see Steve break that out into an actual library but it suits our needs but that's a separate conversation.

Currently it does not have a git diff module. Initially we'd need to create a module for that command and get it merged into Steve's project. He is very responsive and requires tests for all changes.

Alternatively, we could consider switching the git library that we use. I know this one exists:
https://github.com/steveukx/git-js

It has a diff module that we could try to use for this feature. If it works well then we could migrate the other git commands we use. Bottom line, we either need to add a dependency or get some changes merged into gulp-git and then implement them here.

[sebastienbarre]

OK, my gut feeling is that gulp-git is the more stable/popular of the two. I inquired in stephenlacy/gulp-git#97.

[jimthedev]

Thanks!!! I've also started just writing my own wrappers and parsers for v2
so that might be an option for diff. It should pretty much be a regex
On Tue, Oct 13, 2015 at 9:22 AM Sébastien Barré notifications@github.com
wrote:

OK, my gut feeling is that gulp-git is the more stable/popular of the
two. I inquired in stephenlacy/gulp-git#97
stephenlacy/gulp-git#97.

—
Reply to this email directly or view it on GitHub
#7 (comment).

[sebastienbarre]

Hold on, can't this problem be solved already with gulp-git?

• use git.status, then just grep to see if "Changes to be committed" is not there,
• or use git.exec, and execute diff --cached from there? (aka git.exec({args : 'diff --cached'}, function (err, stdout) { ... });)

[jimthedev]

Yes! One question. Does git use different languages? If so then that grep
might not work.
On Tue, Oct 13, 2015 at 9:39 AM Sébastien Barré notifications@github.com
wrote:

Hold on, can't this problem be solved already with gulp-git?

• use git.status
  https://github.com/stevelacy/gulp-git#gitstatusopt-cb, then just
  grep to see if "Changes to be committed" is not there,
• or use git.exec https://github.com/stevelacy/gulp-git#gitexecopt-cb,
  and execute diff --cached from there? (aka git.exec({args : 'diff
  --cached'}, function (err, stdout) { ... });)

—
Reply to this email directly or view it on GitHub
#7 (comment).

[sebastienbarre]

Could be localized, you are correct. Option #2 then, because that would
return an empty string if nothing is staged.

On 10/13/15 10:41 AM, Jim Cummins wrote:

Yes! One question. Does git use different languages? If so then that grep
might not work.
On Tue, Oct 13, 2015 at 9:39 AM Sébastien Barré notifications@github.com
wrote:

Hold on, can't this problem be solved already with gulp-git?

• use git.status
  https://github.com/stevelacy/gulp-git#gitstatusopt-cb, then just
  grep to see if "Changes to be committed" is not there,
• or use git.exec https://github.com/stevelacy/gulp-git#gitexecopt-cb,
  and execute diff --cached from there? (aka git.exec({args : 'diff
  --cached'}, function (err, stdout) { ... });)

—
Reply to this email directly or view it on GitHub
#7 (comment).

—
Reply to this email directly or view it on GitHub
#7 (comment).

[jimthedev]

Ok, I'll make sure to write a test for this in what I currently calling v2.

Side note: At the moment, I think v2 might actually be able to remain on the 1.x branch because as it is written, there should be no adapter breaking changes. The only thing that might make it called 2.x are some small cli changes. TBD.