Skip to content

Broken link fix #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Broken link fix #259

merged 3 commits into from
Oct 10, 2022

Conversation

smyja
Copy link
Contributor

@smyja smyja commented Oct 9, 2022

This fixes the issue #257
I have also added venv to .gitignore since it was mentioned in the contributing guide as the virtual environment.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@mr-c
Copy link
Member

mr-c commented Oct 10, 2022

Ah, those links won't work from external branches in the PR previews, as they refer to commits not present here. Okay, then this is still an improvement, as it should work for the published site.

@mr-c mr-c merged commit 4a04e4b into common-workflow-language:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants