-
-
Notifications
You must be signed in to change notification settings - Fork 66
fixed broken link #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed broken link #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.github.com/en/get-started/quickstart/contributing-to-projects --> did we want this instead since it is off of the main doc fro github?
yes. i think it's better to use that link! |
I agree too that the GitHub link would be better. @bamiwoaluko can you update the pull request, please? |
will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bamiwoaluko look at the very end of this document. There is a line like this one [how-contribute]: ....
. That's where we should update it 😉
CONTRIBUTING.md
Outdated
@@ -68,7 +68,7 @@ so fresh eyes are always welcome. | |||
## Using GitHub | |||
|
|||
If you choose to contribute via GitHub, you may want to look at | |||
[How to Contribute to an Open Source Project on GitHub][how-contribute]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
][how-contribute].
... this is an alias for a link. The actual link is at the end of this document, along with several other links. That's useful in case we need to use the link in multiple places (but update a single place) and also to reduce cluttering in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @bamiwoaluko are you familiar with git and squashing commits? If so you could perhaps try to squash the commits in this PR as there are now 4 commits, but for a small change like this one would be better to have a single commit (easier for others to compare changes later if needed). If you are not sure how to do it, a reviewer can squash it for you when they are ready to merge it 👍 Thanks!
initial link on how to contribute to an open project led to a 404 page. I replaced it with a link to lead to the correct pages
initial link on how to contribute to an open project led to a 404 page. I replaced it with a link to lead to the correct pages