Fix plugin framework tests #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
fix-PluginFramework-tests
branch
from
75d873c
to
e19d44f
Compare
The table below summarized the test names before and after for both PluginFramework test and performance test. | | org_commontk_pluginfwtest | org_commontk_pluginfwtest_perf | |--------|---------------------------|--------------------------------| | Before | CTKPluginFramework | org_commontk_pluginfwtest_perf | | After | CTKPluginFramework | CTKPluginFrameworkTests.perf |
This commit associates a resource lock called "ctkPluginStorage" with each test, this ensures different processes do no attempt to update the database at the same time.
jcfr
force-pushed
the
fix-PluginFramework-tests
branch
from
e19d44f
to
f7c0e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure PluginFramework tests do not run in concurrently: associates a resource lock called
ctkPluginStoragewith each test, this ensures different processes do no attempt to update the database at the same time.Consistently name the PluginFramework performance test. The table below summarized the test names before and after for both PluginFramework test and performance test.
The following tests will now pass independently of the test concurrency level:
CTKPluginFrameworkCTKPluginFramework.perfRemaining failure
The test
CTKPluginFrameworkAppTestsis exiting with the following warning:Since the test is set to run with he environment variable
QT_FATAL_WARNINGS=1, it is failing.Failure observed on the following systems:
QT_FATAL_WARNINGS