Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Remove unnecessary logging information from ctkDICOMDatabase class #1187

Merged
merged 1 commit into from
Jan 25, 2024
Merged

ENH: Remove unnecessary logging information from ctkDICOMDatabase class #1187

merged 1 commit into from
Jan 25, 2024

Conversation

Punzo
Copy link
Contributor

@Punzo Punzo commented Jan 22, 2024

Fix #1186

@Punzo Punzo marked this pull request as ready for review January 22, 2024 16:09
@Punzo Punzo mentioned this pull request Jan 22, 2024
Closed
@Punzo
Copy link
Contributor Author

Punzo commented Jan 22, 2024

@lassoan @jcfr

@Punzo Punzo mentioned this pull request Jan 22, 2024
Merged
lassoan
lassoan reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make some adjustments (see comments inline) but overall I like this simple solution: if something is important for user to know or useful for troubleshooting (and does not happen to frequently) then log the message, otherwise remove the log.

Libs/DICOM/Core/ctkDICOMDatabase.cpp Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Outdated Show resolved Hide resolved
@Punzo
Copy link
Contributor Author

Punzo commented Jan 23, 2024

I would make some adjustments (see comments inline) but overall I like this simple solution: if something is important for user to know or useful for troubleshooting (and does not happen to frequently) then log the message, otherwise remove the log.

ok and thanks for the review. I have applied it! @lassoan

lassoan
lassoan approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@lassoan lassoan merged commit 8d358c6 into commontk:master Jan 25, 2024
3 checks passed
@Punzo Punzo deleted the fixDebugLogging branch January 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"SQL worked" messages on the console
2 participants
@Punzo @lassoan