Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 support #784

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Add python3 support #784

merged 1 commit into from
Feb 14, 2018

Conversation

CJGoch
Copy link
Contributor

@CJGoch CJGoch commented Feb 8, 2018

Ifdef where necessary, use statements valid for python 3 and 2.6+ where
possible.

Ifdef where necessary, use statements valid for python 3 and 2.6+ where
possible.
@CJGoch
Copy link
Contributor Author

CJGoch commented Feb 9, 2018

Is there any additional information available beyond the CircleCI message
command ~/CTK/CMake/CircleCI/run.sh qt4 $CIRCLE_SHA1 $CIRCLE_BRANCH $SITE_BUILD_TYPE took more than 10 minutes since last output
?

I tried building it on a commontk/ctk-test:opengl-qt4 container with the following conifguration
cmake -DCTK_QT_VERSION:STRING=4 -DCTK_ENABLE_Widgets:BOOL=ON -B/usr/src/bin/ -H/usr/src/CTK/

And the build worked withouth a hitch. Unless I am mistaken it does not build Python anway, so I would assume that any changes I made should not affect the CircleCI client either way.

@nolden
Copy link
Member

nolden commented Feb 9, 2018

@jcfr any ideas? Can we just go ahead and merge this?

@jcfr
Copy link
Member

jcfr commented Feb 9, 2018 via email

@jcfr
Copy link
Member

jcfr commented Feb 14, 2018

Thanks for the PR 👍 , I am reviewing it now.

so I would assume that any changes I made should not affect the CircleCI client either way.

This is correct. The builds are currently done without python enabled.

took more than 10 minutes since last output

I will have a look

@jcfr jcfr merged commit 0d43ccf into commontk:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants