Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Reduce storage path length of files stores in DICOM database #942

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

lassoan
Copy link
Member

@lassoan lassoan commented Nov 7, 2020

Study, series, and SOP instance UIDs were used to generate path for data sets copied into the DICOM database.
When database folder path or UIDs were long, this path length could very easily become longer than the file system maximum path limit
(about 256 characters on some systems, for example on Windows or when writing CDs).

Added useShortStoragePath flag so that developers can still switch between full and shortened paths.

Study, series, and SOP instance UIDs were used to generate path for data sets copied into the DICOM database.
When database folder path or UIDs were long, this path length could very easily become longer than the file system maximum path limit
(about 256 characters on some systems, for example on Windows or when writing CDs).

Added useShortStoragePath flag so that developers can still switch between full and shortened paths.
@lassoan lassoan requested a review from cpinter November 7, 2020 05:27
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@cpinter cpinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be a bit harder to identify which folder is which, but I think the gain is bigger. Looks good, thank you.

@lassoan lassoan merged commit 7210c5b into commontk:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants