Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filename sanitization in DICOM export #952

Merged

Conversation

lassoan
Copy link
Member

@lassoan lassoan commented Feb 17, 2021

When exporting a DICOM series from the database to the file system, subfolders are created from DICOM fields content.
Sanitization of DICOM fields to be used as filename was not sufficient (allowed various non-ASCII and special characters).

When exporting a DICOM series from the database to the file system, subfolders are created from DICOM fields content.
Sanitization of DICOM fields to be used as filename was not sufficient (allowed various non-ASCII and special characters).
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this - it's been a pain in the side for a long time!

LGTM 👍

@pieper pieper merged commit 9a9573e into commontk:master Feb 17, 2021
@lassoan lassoan deleted the dicom-export-folder-name-sanitization branch February 17, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants