Backport security fixes to patched-DCMTK-3.6.6_20210115
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is meant to be integrated at least in CTK and 3DSlicer. I know that there is work in progress for upgrading DCMTK to the latest version in these projects (Slicer/Slicer#6709) but I would like to know if this can be a step in the mean time. |
|
Hi, please let me know if this PR is relevant or if we need to close it. |
|
@jcfr push this branch into |
Fixed a possible NULL pointer dereference that could occur when reading an invalid DICOM file from stdin. Loading a file from the file system and receiving data over a network connection were not affected by this bug. Thanks to Sharon Brizinov and Noam Moshe from Claroty Research for the bug report and sample file. (cherry picked from commit DCMTK/dcmtk@3e996a2) Co-authored-by: malbi <mathieualbi33@hotmail.fr>
Thanks to Sharon Brizinov >sharon.b@claroty.com> and Noam Moshe from Claroty Research for the bug report and sample files. This closes DCMTK issue #1021. (cherry picked from commit DCMTK/dcmtk@f06a867) Co-authored-by: malbi <mathieualbi33@hotmail.fr>
jcfr
force-pushed
the
patched-DCMTK-3.6.6_20240418
branch
from
119e1ae
to
8633090
Compare
jcfr
changed the title
patched-DCMTK-3.6.6_20210115
|
@malbi Thanks for the contribution 🙏 The proposed changes make sense 💯 Thanks for addressing the conflicts while cherry-picking those. Warning While we are conveniently using the branch name |
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport security fixes from the following post https://forum.dcmtk.org/viewtopic.php?t=5192 because of the folowing CVE: CVE-2022-2119 and CVE-2022-2120