-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDPred2: Effective sample size, cores used, hyperparameters #173
Conversation
MINOR version when you add functionality in a backward compatible manner
Ok. I looked through the rest of this PR as is, and looks good to me. Just waiting for the test script to finish. |
Don't know if this PR introduced this test crash with the LDpred2 test script:
Do you also see this? |
Ah, yes! It's because I removed running both the auto and inf mode in that part of the tests. |
@espenhgn Turned out to be the memory issue again as termination due to memory is not captured as an error.. My impression from watching the process is that memory usage peaks at about 8GB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The test crash I encountered appears to be memory related
…/comorment/containers into deepchocolate/ldpred2_parameters
Fixes #149 and #175
Changes proposed in this pull request:
snp_ldsc
uses multiple cores--n-cases
) and nr controls (--n-controls
)--hyper-p-max
) tosnp_ldpred2_auto
--name-score
if givenBefore submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.