Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwas.py: fixed gwas demo run and IID column position #234

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

ttfiliz
Copy link
Contributor

@ttfiliz ttfiliz commented Feb 29, 2024

Fixes #230, #232

Changes proposed in this pull request:

-Renamed Plink2 case/control GWAS output files to *.logistic (from *.firth and *.logistic.hybrid)
-Added --firth option to gwas.py

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@ttfiliz ttfiliz requested a review from ofrei February 29, 2024 13:58
@ttfiliz ttfiliz changed the title Fix 230 Fix 230, 232 Feb 29, 2024
Copy link
Contributor

@espenhgn espenhgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ttfiliz! Looks good. Can you bump the version.py file and update the CHANGELOG.md for this to be merged?

@ttfiliz ttfiliz requested a review from espenhgn March 5, 2024 11:08
set version as 1.8.1
set version as 1.8.1
@espenhgn espenhgn changed the title Fix 230, 232 gwas.py: fixed gwas demo run and IID column position Mar 5, 2024
@espenhgn espenhgn merged commit d4ef7de into comorment:main Mar 5, 2024
3 checks passed
@ttfiliz ttfiliz deleted the fix230 branch March 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GWAS demo run 1 is not working
2 participants