Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.12: Staking #12

Merged
merged 9 commits into from
Jun 20, 2019
Merged

2.4.12: Staking #12

merged 9 commits into from
Jun 20, 2019

Conversation

deanpress
Copy link
Member

No description provided.

Copy link
Contributor

@jeroenptrs jeroenptrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could extend interfaces so you don't need to do (x as any) but let's do that in a separate PR, since it's less about functionality and more about DX

@@ -1,2 +1,2 @@
*
# *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp or intentional?

Copy link
Member Author

@deanpress deanpress Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional. ARK Core normally expects plugins as git submodules, which is something I'd like to do later, but is not a priority right now.

constructor() {
super();
this.data.type = 104;
this.data.fee = feeManager.get(100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not this.data.type?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now know what you mean 👍

@deanpress deanpress merged commit e36cdf8 into 2.4.12 Jun 20, 2019
@deanpress deanpress deleted the 2.4-staking branch September 28, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants