fix DestructArray test

[Vipul-Cariappa]

Description

makes valgrind happy, as the call to new and delete now match

@aaronj0, I believe you wrote this test. Please verify if my changes are fine.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

• Bug fix
• New feature
• Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

• I have read the contribution guide recently

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.46%. Comparing base (0b1271a) to head (24fb3c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   81.46%   81.46%           
=======================================
  Files           9        9           
  Lines        4213     4213           
=======================================
  Hits         3432     3432           
  Misses        781      781           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[mcbarton]

@Vipul-Cariappa If this PR makes Valgrind happy, then does that mean we can remove GTEST_SKIP() << "XFAIL due to Valgrind report"; for this test now?

[Vipul-Cariappa]

If this PR makes Valgrind happy, then does that mean we can remove GTEST_SKIP() << "XFAIL due to Valgrind report"; for this test now?

Yes, we should be able to remove the GTEST_SKIP(). In my system, the test is not skipped when run with valgrind for some reason, and I did not realise that I should remove that line.
Will fix it once the OSX CI is running normally again.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[aaronj0]

LGTM!

[mcbarton]

If this PR makes Valgrind happy, then does that mean we can remove GTEST_SKIP() << "XFAIL due to Valgrind report"; for this test now?

Yes, we should be able to remove the GTEST_SKIP(). In my system, the test is not skipped when run with valgrind for some reason, and I did not realise that I should remove that line. Will fix it once the OSX CI is running normally again.

I tried removing the gtest_skip for the test in this PR here #714 and Valgrind errors, so at least some Valgrind issues with this test appear to still exist

[Vipul-Cariappa]

I tried removing the gtest_skip for the test in this PR here #714 and Valgrind errors, so at least some Valgrind issues with this test appear to still exist

I wonder if this is due to the release build. In my local machine (debug build), Valgrind passes without any complaints. I will test this theory tomorrow.