Adding new page to Website for Success Stories (Jun, Garima, Baidyanath, etc.) #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidlange6 / @vgvassilev Please review and suggest if this approach is OK |
|
this should make a page, yes (called carpe-diem - probably not the right one) - did the readme instructions work for you in order to test this locally? |
QuillPusher
force-pushed
the
AddSuccessStoriesPage
branch
from
aec2a0d to
3f6c976
Compare
|
|
@davidlange6 , @vgvassilev updated "Student Success Stories" page is available for your review |
QuillPusher
force-pushed
the
AddSuccessStoriesPage
branch
3 times, most recently
from
0117b84 to
32aa23d
Compare
vgvassilev
reviewed
Oct 24, 2023
1. Added a new page to host Student Success Stories - Garima Singh - Jun Zhang - Baidyanath Kundu 2. Added the "stories" page to header navigation under the "Results" menu 3. Added Credits sections to each profile, and Squashed commits for simplicity
vgvassilev
force-pushed
the
AddSuccessStoriesPage
branch
from
32aa23d to
1b1ddc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if adding an .md file is enough to add a new page to CR website (I haven't worked with Jekyl websites before), please guide if I missed something.
I did include some header tags based on what I saw in other pages on the website:
title: "Success Stories"
layout: gridlay
excerpt: "Student Success Stories"
sitemap: false
permalink: /carpe-diem/