Skip to content

Update testing instructions (test after installation) #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcbarton
Copy link
Collaborator

This PR updates the instructions so that the tests are performed after installation. @alexander-penev can you merge?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.83%. Comparing base (f2d118d) to head (b487e05).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files          15       15           
  Lines         600      600           
  Branches       59       59           
=======================================
  Hits          347      347           
  Misses        253      253           

@mcbarton
Copy link
Collaborator Author

@anutosh491 can you merge this PR? It just changes the instructilns so you install within the mamaba environment before testing. The previous instructions were causing confusion due to the tests not being able to find the library if not installed.

@alexander-penev alexander-penev self-requested a review May 19, 2024 16:52
@alexander-penev alexander-penev merged commit de10302 into compiler-research:main May 19, 2024
@mcbarton mcbarton deleted the Update-test-instructions-non-wasm branch May 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants