Skip to content

Add tests for xmagics, os, xutils, xinterpreter #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

tharun571
Copy link
Contributor

No description provided.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
Copy link
Collaborator

sys/wait.h is for unix systems only. You will need a different header for Windows.

@tharun571 tharun571 changed the title Add tests for xmagics, os, xutils Add tests for xmagics, os, xutils, xinterpreter May 22, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
Copy link
Collaborator

unistd.h is also unix only.

@tharun571
Copy link
Contributor Author

@mcbarton the handler function which has backtrace and backtrace_symbols_fd are also not available in windows. Shall I change that particular test for unix only?

@mcbarton
Copy link
Collaborator

@tharun571 Maybe you could try one of the suggestions from this stackoverflow page where they talk about Windows equivalents https://stackoverflow.com/questions/341817/is-there-a-replacement-for-unistd-h-for-windows-visual-c .

@tharun571
Copy link
Contributor Author

Also is there a way to check windows build in local? or should I push the code everytime to check?

@mcbarton
Copy link
Collaborator

Also is there a way to check windows build in local? or should I push the code everytime to check?

If you have access to a Windows machine you could run the commands in the ci. There are currently no Windows instructions in the documentation. I will add at some point.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (6692a45) to head (2f37664).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   70.09%   75.08%   +4.98%     
==========================================
  Files          17       17              
  Lines         602      602              
  Branches       59       59              
==========================================
+ Hits          422      452      +30     
+ Misses        180      150      -30     

see 3 files with indirect coverage changes

see 3 files with indirect coverage changes

@anutosh491 anutosh491 marked this pull request as draft May 23, 2024 05:53
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator

Converting to draft, let us know when the PR is ready for review (after maybe squashing the commits too)

@tharun571
Copy link
Contributor Author

@anutosh491 this covers most of #114. Having some trouble with complete_request. Will push that later.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491 anutosh491 marked this pull request as ready for review May 23, 2024 06:26
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for maybe one more review before we merge this.
cc @mcbarton

@vgvassilev vgvassilev merged commit 79ae8b0 into compiler-research:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants