Refactor CMakeLists.txt #164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 80.14% 80.14%
=======================================
Files 19 19
Lines 972 972
Branches 93 93
=======================================
Hits 779 779
Misses 193 193 |
| # ENV (https://github.com/emscripten-core/emscripten/commit/6d9681ad04f60b41ef6345ab06c29bbc9eeb84e0) | ||
| set(EMSCRIPTEN_FEATURES "${EMSCRIPTEN_FEATURES} -s \"EXTRA_EXPORTED_RUNTIME_METHODS=[ENV']\"") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
These are redundant as are being addressed through macro(xeus_cpp_set_common_options target_name) so can be totally removed from here.
There was a problem hiding this comment.
I think some flags are still missing in the macro (-fexceptions and /EHsc, I may have missed others).
There was a problem hiding this comment.
Hmm, having a look !
There was a problem hiding this comment.
Yupp those were the only ones. Should be ready now !
|
@vgvassilev this should be ready (P.S i made similar changes on xeus-r few days ago and I realized they would be applicable on xeus-cpp too so pretty confident :) ) |
anutosh491
force-pushed
the
improve_cmakelists.txt
branch
from
0987f9f to
04aa5a6
Compare
anutosh491
force-pushed
the
improve_cmakelists.txt
branch
from
974a851 to
81de961
Compare
| @@ -347,7 +332,6 @@ macro(xeus_cpp_create_target target_name linkage output_name) | |||
| # Curl initialised specifically for xassist | |||
| target_link_libraries(${target_name} PUBLIC ${XEUS_CPP_XEUS_TARGET} clangCppInterOp pugixml argparse::argparse curl) | |||
| else () | |||
| # TODO : Add curl support for emscripten | |||
There was a problem hiding this comment.
Removed TODO which can't be resolved as mentioned here (emscripten-forge/recipes#1332 (comment))
The PR tried adding libcurl-static on emscripten-forge but the above comment explains why the recipe can't be put to use.
Removed redundancy and adds more consistency especially for the wasm build