Skip to content

Minor: add string quotes in command #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

faze-geek
Copy link
Contributor

@faze-geek faze-geek commented Nov 4, 2024

Description

On Rocky 8 linux on bash -

±|main|→ mamba install notebook cmake cxx-compiler xeus-zmq nlohmann_json=3.11.3 jupyterlab CppInterOp cpp-argparse<3.1 pugixml doctest -c conda-forge
bash: 3.1: No such file or directory

As far as I know, bash interprets < as a redirection operator. Now it will work with all terminals.

Type of change

Please tick all options which are relevant.

  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (e122401) to head (9ae9c0c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files          19       19           
  Lines         972      972           
  Branches       93       93           
=======================================
  Hits          779      779           
  Misses        193      193           

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you!

@vgvassilev vgvassilev merged commit 3df7988 into compiler-research:main Nov 4, 2024
8 checks passed
@faze-geek faze-geek deleted the patch-1 branch November 4, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants