Skip to content

Documentation: fixed create conda environment command in CONTRIBUTING.md #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

b1shtream
Copy link
Contributor

@b1shtream b1shtream commented Mar 23, 2024

Description

When I was trying to build the project by following CONTRIBUTING.md
I found an error after running the command conda create -f environement-dev.yml.

Expected

The command reads the environment specifications from the YAML file and creates a new conda environment accordingly.

Found

An error message that states that the command is incorrent.

What I Did

To properly create a new conda environment using a specified YAML file(environment-dev.yaml), I changed the command from conda create -f environment-dev.yml to conda env create -f environment-dev.yml.
Ouput: Successfully creates a new coda environment

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.29%. Comparing base (d70416a) to head (34ed8fc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   49.29%   49.29%           
=======================================
  Files          15       15           
  Lines         779      779           
=======================================
  Hits          384      384           
  Misses        395      395           

@vgvassilev
Copy link
Contributor

Could you improve the commit message and the PR description?

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and as pointed out, you can update the commit message!

@b1shtream
Copy link
Contributor Author

@anutosh491 Implemented the suggested changes, is it fine now??

@anutosh491 anutosh491 changed the title CONTRIBUTING.md: fix create conda environment command Documentation: fixed create conda environment command in CONTRIBUTING.md Mar 24, 2024
@anutosh491 anutosh491 merged commit 6150986 into compiler-research:main Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants