Skip to content

Update example notebook to use c++17 kernel #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2024

Conversation

mcbarton
Copy link
Collaborator

Previously the example notebook made use of the C++14 kernel . This PR updates it to use the C++17 kernel.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.42%. Comparing base (d203fdf) to head (39481b1).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   51.60%   52.42%   +0.81%     
==========================================
  Files          15       15              
  Lines         593      599       +6     
==========================================
+ Hits          306      314       +8     
+ Misses        287      285       -2     

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 2e1e6b8 into compiler-research:main May 12, 2024
@mcbarton mcbarton deleted the update-example-notebook branch May 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants