add support for the vFile:fstat packet #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Oct 7, 2024
compnerd
reviewed
Oct 7, 2024
Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for lldb's
vFile:fstatpacket to ds2 debug and platform sessions. Fixes #135.Overview
fstatmethod to theFileclass and implement it for POSIX. Leave the Windows implementation unimplemented (as is the rest ofFile)File::fstatmethod when isvFile:fstatpacket is received.Problem Details
Several of the lldb tests rely on
vFile:fstatto fetch files from the device, and these tests fail against ds2 because it is not implemented.The
vFile:fstatpacket isn't documented. The implementation is based on the expectation of the lldb test caseTestGdbRemotePlatformFile.TestGdbRemotePlatformFile.test_platform_file_fstat_llgs, which now passes with this change.Validation
Once this PR and a some additionalchanges are merged, most of the
TestGdbRemotePlatformFiletests succeed with ds2 running on Android and Linux and can be enabled in CI. They do not all pass with this PR alone.