allow ELF link audit version <= LAV_CURRENT #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Check the link audit version the ELF debug header is not greater than the current version,
LAV_CURRENTrather than exactly equal to it.Background
On a recent Linux host,
LAV_CURRENTis defined as 2, while modules may be 1 or 2. Changing the check this way allows both v1 and v2 modules to load, which is safe since the header layouts did not between versions.Validation
Manually ran
image listfrom lldb when attached to aremote-linuxds2 server (on Fedora 40) and verified the list of modules matches the list generated when doing the same against an lldb-server instance.