-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure sym server] Upload the DLLs #724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this conceptually, but I think that I want to see if we can collapse these into a single run. That would reduce the overall impact of the step as we can upload more items in parallel/
Doing a collapsed variant run at https://github.com/thebrowsercompany/swift-build/actions/runs/8333794115 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is unfortunate, both forms fail. We can take a look at this later I suppose, merging this to avoid blocking.
@compnerd We can't use a single invocation because microsoft/action-publish-symbols#32 |
Upload the PE files generated by the ArcCore build to the Azure symbol server in addition to the PDBs.
Also make the symbol search pattern explicit as the default wasn't gathering all desired files.