WindowsCore: remove Foundation dependency #11
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Remove the Foundation dependency as we used it for a single purpose: to convert to a UTF16 string representation for use on Windows. Introduce a `withUTF16CString` helper that avoids Foundation for the single use.
compnerd
force-pushed
the
compnerd/foundational
branch
from
3dc18f4 to
7b9bfea
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Foundation dependency from WindowsCore by implementing a custom UTF-16 string conversion helper. The main purpose is to eliminate the heavy Foundation dependency that was only used for converting strings to UTF16 encoding for Windows APIs.
- Implements a custom
withUTF16CStringextension method on String - Replaces Foundation import with FoundationEssentials
- Updates the single usage site to use the new helper method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/WindowsCore/String+Extensions.swift | Adds new String extension with withUTF16CString method for UTF-16 conversion |
| Sources/WindowsCore/NTAPI.swift | Updates import and replaces Foundation's withCString call with custom helper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| pBuffer.baseAddress?.initialize(from: pSource, count: count) | ||
| } | ||
| }) == nil { | ||
| _ = pBuffer.initialize(from: self.utf16) |
There was a problem hiding this comment.
The initialize(from:) method on UnsafeMutableBufferPointer expects a sequence, but self.utf16 returns a String.UTF16View which may not provide the expected initialization behavior. Consider using pBuffer.baseAddress?.initialize(from: self.utf16, count: count) or explicitly iterate through the UTF16 view to ensure proper initialization.
| _ = pBuffer.initialize(from: self.utf16) | |
| pBuffer.baseAddress?.initialize(from: self.utf16, count: count) |
Copilot uses AI. Check for mistakes.
Remove the Foundation dependency as we used it for a single purpose: to convert to a UTF16 string representation for use on Windows. Introduce a
withUTF16CStringhelper that avoids Foundation for the single use.