Async alias builder #137

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

Contributor

And bump batch version to v0.5
And cache configs on the root builder.

Bjorn Stromberg added some commits Dec 12, 2013
Bjorn Stromberg cache config on the root builder, buildAliases needs to be async to a…
…void exploding on large components.
a63f0b8
Bjorn Stromberg cache config on the root builder, buildAliases needs to be async to a…
…void exploding on large components.
311c83f
Contributor

A little background on this issue. I was having problems with "too many files open" on one of my projects - #66 😢

Since this project uses batch I thought I'd just bump the batch version number and see if that solved my problem.

It got rid of the "too many open files" problem and replaced it with callbacks never getting called 🌵

It turns out that batch silently fails when the maximum call stack size is exceeded. 😠

So, I wrapped the recursive calls in buildAliases in a process.nextTick to avoid the issue. You should really fix this in batch, though.

Contributor

why not just open a PR or issue in batch?

Contributor

Because it still needs to be fixed here and I have no idea what requirements batch has. At least this is node only and I don't have to worry about process.nextTick not existing.

Contributor

@visionmedia plz fix batch :D

Contributor
tj commented Dec 29, 2013

dont need aliases anymore

@tj tj closed this Dec 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment