Async alias builder #137
Async alias builder #137
Conversation
…void exploding on large components.
…void exploding on large components.
|
A little background on this issue. I was having problems with "too many files open" on one of my projects - #66 😢 Since this project uses batch I thought I'd just bump the batch version number and see if that solved my problem. It got rid of the "too many open files" problem and replaced it with callbacks never getting called 🌵 It turns out that batch silently fails when the maximum call stack size is exceeded. 😠 So, I wrapped the recursive calls in buildAliases in a process.nextTick to avoid the issue. You should really fix this in batch, though. |
|
why not just open a PR or issue in batch? |
|
Because it still needs to be fixed here and I have no idea what requirements batch has. At least this is node only and I don't have to worry about process.nextTick not existing. |
|
@visionmedia plz fix batch :D |
|
dont need aliases anymore |
And bump batch version to v0.5
And cache configs on the root builder.