Skip to content

Divider SwiftUI #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 19, 2024
Merged

Divider SwiftUI #24

merged 11 commits into from
Nov 19, 2024

Conversation

VislovIvan
Copy link
Collaborator

  • Model (color, size, orientation)
  • Divider SwiftUI
  • Preview

@VislovIvan
Model and Component
1719e92
@VislovIvan
Divider Preview
07bcf23
@VislovIvan
Fix Preview
f018c3e 
Deleted <Custom: View> from UniversalColorPicker
mikhailChelbaev
mikhailChelbaev requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mikhailChelbaev mikhailChelbaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo 👏
just a few minor things to fix

@VislovIvan
Some fix
b734426 
- Docs
- Renamed Orientation to DividerOrientation and separated
- Added Divider into App
@VislovIvan
Merge remote-tracking branch 'origin/dev' into Divider-SwiftUI
15415b0
mikhailChelbaev
mikhailChelbaev approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mikhailChelbaev mikhailChelbaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mikhailChelbaev mikhailChelbaev changed the base branch from dev to main November 18, 2024 11:25
@mikhailChelbaev mikhailChelbaev changed the base branch from main to dev November 18, 2024 11:25
@VislovIvan
Fix Preview
9821894 
Preview sorted in alphabetical order
VislovIvan and others added 5 commits November 18, 2024 22:17
@VislovIvan
UKDivider and DividerPreview
ee22594
@VislovIvan
Documentation
03ed41a
@VislovIvan
Some fix
5c18915 
- func setup to func style fix
- added func shouldUpdateLayout
- removed unused func layoutSubviews
@mikhailChelbaev
refactor
a4a993d
@VislovIvan
Merge pull request #25 from componentskit/Divider-UIKit
871bad7 
Divider UIKit
@VislovIvan VislovIvan merged commit 9dfaf81 into dev Nov 19, 2024
@VislovIvan VislovIvan deleted the Divider-SwiftUI branch November 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailChelbaev mikhailChelbaev mikhailChelbaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VislovIvan @mikhailChelbaev