Fix possible nil in extended docker-compose.yml configuration #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @misak113, |
|
An example of not working configuration is here:
services:
app1:
image: alpine
command: ["sleep", "1000"]
extends:
file: parent.yml
service: app1
services:
app1:
# app1: {}The following command: docker-compose up -dIs failing with error: If you add empty object It can be fixed with my fix here or either the more suitable error message like following: The other option to fix this: return nil, fmt.Errorf("cannot extend service %q in %s: service has to be object", name, filename) |
|
LGTM, but for opensource contributions we require all commit to be signed-off |
ndeloof
approved these changes
Jan 3, 2023
misak113
force-pushed
the
mz/fix-nil-extend
branch
2 times, most recently
from
5aab1ae to
6bc67ca
Compare
in practice, the missing service name in extended configuration means that nothing is extended
current state was that the docker-compose command fails with following error:
panic: interface conversion: interface {} is nil, not map[string]interface {}
goroutine 1 [running]:
github.com/compose-spec/compose-go/loader.loadServiceWithExtends({0xc0007c4230, 0x50}, {0xc000502880, 0x7}, 0xc0005fc720?, {0xc0007c4230, 0x40}, 0xc0004d22d0?, 0xc000480390, 0xc0007cb1f8)
github.com/compose-spec/compose-go@v1.6.0/loader/loader.go:511 +0x6ab
Signed-off-by: Michael Zabka <zabka.michael+scarlett@gmail.com>
misak113
force-pushed
the
mz/fix-nil-extend
branch
from
6bc67ca to
8c5f96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in practice, the missing service name in extended configuration means that nothing is extended
current state was that the docker-compose command fails with following error: