Skip to content

merge exposes, heathchecks.test #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

merge exposes, heathchecks.test #321

merged 1 commit into from
Nov 24, 2022

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Nov 24, 2022

glours
glours approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, can we also add a test to test the uniqueness of the expose attribute?

@ndeloof
merge exposes, heathchecks.test
5c50f88 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof merged commit 999ce24 into compose-spec:master Nov 24, 2022
@ndeloof ndeloof deleted the 9756 branch November 24, 2022 14:27
@ndeloof ndeloof mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compose doesn't correctly merge exposes, heathchecks.test, and other arrays
2 participants
@ndeloof @glours