sync compose-spec #339
Merged
sync compose-spec #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
This could be automated through Github Actions. See https://github.com/ergebnis/composer-normalize/blob/7325813b350f5208a3ee81c20b66934a58f2f2aa/.github/workflows/update.yaml for an example. |
laurazard
reviewed
Jan 11, 2023
| "driver":{"type": "string"}, | ||
| "options":{"$ref": "#/definitions/list_or_dict"} | ||
| }, | ||
| "capabilities": {"$ref": "#/definitions/list_of_strings"}, |
There was a problem hiding this comment.
are these whitespace changes intentional?
There was a problem hiding this comment.
They exist in the reference compose-spec.json file - maybe we should use a code formatter to prevent such issues
laurazard
approved these changes
Jan 11, 2023
glours
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close docker/compose#8167
also define a make target to get latest spec from reference repo