ci: bump to Go 1.20 & improve linting #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Feb 15, 2023
* Use Go 1.20 & 1.19 in CI (1.18 is now EOL)
* `go.mod` now targets 1.19 - in the future, this
should be safe to raise to the higher version as
we use the new `-compat` flag properly
* Update to latest golangci-lint
* Move linting to happen as part of test job to ensure
that it runs across the matrix of Go & OS versions,
as some lint issues can be Go version or OS/platform
specific
* Upgrade `distribution/v3` to latest
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.modnow targets 1.19 - in the future, this should be safe to raise to the higher version as we use the new-compatflag properlydistribution/v3to latest