introduce WithDependentServices to run fn on services in reverse dependency order #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
WithDependentServices
branch
from
394aa15 to
03a6512
Compare
glours
approved these changes
Feb 28, 2023
types/types.go
Outdated
| // | ||
| // When marshaled to YAML, nil command fields will be omitted if `omitempty` | ||
| // is specified as a struct tag. Explicitly empty commands (i.e. `[]` or `''`) | ||
| // is specified as a struct tag. Explicitly empty commands (i.e. `[]` or `”`) |
types/types.go
Outdated
| // When marshaled to JSON, the `omitempty` struct must NOT be specified. | ||
| // If the command field is nil, it will be serialized as `null`. | ||
| // Explicitly empty commands (i.e. `[]` or `''`) will serialize to an empty | ||
| // Explicitly empty commands (i.e. `[]` or `”`) will serialize to an empty |
There was a problem hiding this comment.
Oops, I'm fixing up #355 so we won't have to ever think about this again (had to deal with some Windows oddities with the linter 😒)
ndeloof
force-pushed
the
WithDependentServices
branch
from
03a6512 to
8d8560f
Compare
milas
approved these changes
Feb 28, 2023
glours
approved these changes
Mar 1, 2023
ndeloof
force-pushed
the
WithDependentServices
branch
3 times, most recently
from
dc55bcc to
80c0d63
Compare
…ndency order Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
WithDependentServices
branch
from
80c0d63 to
abe1044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.