Skip to content

Conversation

milas
Copy link
Member

@milas milas commented Apr 11, 2023

Missing Go struct tag here, so the field name in YAML was actually dockerfileinline.

(This isn't a breaking change: it was a mistake/broken before and not even usable since the schema validation would prevent you from using the typo'd field name.)

See also:

Missing Go struct tag here, so the field name in YAML was actually
`dockerfileinline`.

(This isn't a breaking change: it was a mistake/broken before and
not even usable since the schema validation would prevent you from
using the typo'd field name.)

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas added the bug Something isn't working label Apr 11, 2023
@milas milas requested review from ndeloof, glours and laurazard April 11, 2023 18:59
@milas milas self-assigned this Apr 11, 2023
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DYefimov

This comment was marked as off-topic.

@ndeloof ndeloof merged commit 270da2d into compose-spec:master Apr 12, 2023
@milas milas deleted the fix-dockerfile-inline branch April 12, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants