Skip to content

fix !reset support to override attributes with custom yaml name #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

fix !reset support to override attributes with custom yaml name #398

merged 1 commit into from
May 11, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented May 10, 2023 •
edited
Loading

After #392 support for !reset can't rely anymore on mapstructure tags to get the yaml name for a go struct field

closes docker/compose#8866

@ndeloof ndeloof force-pushed the reset_read_only branch from e6bb177 to e18a2b9 Compare May 10, 2023 08:06
@ndeloof
fix !reset support to override attributes with custom yaml name
d048fc3 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof force-pushed the reset_read_only branch from e18a2b9 to d048fc3 Compare May 10, 2023 13:51
@milas milas merged commit c21018f into compose-spec:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

@glours glours Awaiting requested review from glours

@laurazard laurazard Awaiting requested review from laurazard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_only override is ignored by docker compose
2 participants
@ndeloof @milas