Skip to content

check conflict between scale and container_name #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2023
Merged

check conflict between scale and container_name #498

merged 1 commit into from
Nov 21, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Nov 21, 2023

This adds a validation that container_name doesn't conflict with scale set to > 1
Also introduce getScale and setScale to manage sync with deploy.replicas

@ndeloof ndeloof requested review from glours and milas November 21, 2023 19:07
@ndeloof ndeloof force-pushed the scale_container_name branch from 6c0c2e9 to 0973988 Compare November 21, 2023 19:07
@ndeloof
check conflict between scale and container_name
5f94dcd 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof force-pushed the scale_container_name branch from 0973988 to 5f94dcd Compare November 21, 2023 19:15
@ndeloof ndeloof enabled auto-merge (rebase) November 21, 2023 20:50
@ndeloof ndeloof merged commit 6e38069 into compose-spec:main Nov 21, 2023
@ndeloof ndeloof deleted the scale_container_name branch November 22, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@milas milas Awaiting requested review from milas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndeloof @glours