Skip to content

Expose build.shm_size as Build.ShmSize #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

Expose build.shm_size as Build.ShmSize #514

merged 2 commits into from
Dec 20, 2023

Conversation

lionello
Copy link
Contributor

@lionello lionello requested a review from ndeloof as a code owner December 20, 2023 18:40
ndeloof
ndeloof approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase to get latest schema + force push, then we can merge

@lionello
expose build.shm_size as Build.ShmSize
a46d6c5 
Signed-off-by: Lionello Lunesu <lio+git@lunesu.com>
@lionello
use filepath.Join
2af0a3f 
Signed-off-by: Lionello Lunesu <lio+git@lunesu.com>
@ndeloof ndeloof merged commit 1aa0c8a into compose-spec:main Dec 20, 2023
@lionello lionello deleted the add-shm_size branch December 20, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionello @ndeloof