Skip to content

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jan 23, 2024

storage_opt is already defined by compose-spec schema but we didn't had binding set in go structs for it

see docker/compose#11395

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from glours, milas and jhrotko January 23, 2024 15:18
Copy link
Collaborator

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was checking our docs page for v3 and there is no reference for storage_opt. Only in v2 docs. Is this something that needs to be added? @ndeloof

@ndeloof
Copy link
Collaborator Author

ndeloof commented Jan 23, 2024

@jhrotko compose file v2 vs v3 is obsolete, compose-specification merged those into a single (version-less) file format with all legacy attributes supported

Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 73c4a98 into compose-spec:main Jan 23, 2024
@ndeloof ndeloof deleted the storage_opt branch January 24, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants